CCM-15190: misc fixes#117
Merged
Merged
Conversation
With set -euo pipefail, this grep | ... | grep pipeline will terminate the
script when there is no matching docker/${name} entry in .tool-versions (a
normal case). The command substitution should tolerate no matches and fall back
to latest.
content=$(grep ...; grep -v ... ||: | grep -v ...) has two issues under set -euo pipefail: (1) the first grep will exit non-zero when there are no Docker- specific entries, which will abort the script; and (2) due to ||/| precedence, the grep -v "^#" filter is not applied when the second grep -v succeeds. This can break Docker builds in repos without docker/ entries in .tool-versions.
docker rmi --force "$(...)" quotes the list of dangling image IDs, which can collapse multiple IDs into a single argument and prevent cleanup from working correctly. Collect the IDs and pass them as separate arguments.
rhyscoxnhs
approved these changes
Jun 12, 2026
mjewildnhs
approved these changes
Jun 12, 2026
sidnhs
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Misc. fixes, noticed by copilot review.
Context
Summary:
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.